chore: improve testing of suffix indexing#1080
Merged
Merged
Conversation
oracle-contributor-agreement
Bot
added
the
OCA Verified
benmss
force-pushed
the
703-improve-commit-finder-tests
branch
from
ee4b3b8 to
dcdabb3
Compare
behnazh-w
reviewed
May 20, 2025
behnazh-w
approved these changes
May 21, 2025
benmss
force-pushed
the
703-improve-commit-finder-tests
branch
from
5da9490 to
6b7dea8
Compare
Signed-off-by: Ben Selwyn-Smith <benselwynsmith@googlemail.com>
Signed-off-by: Ben Selwyn-Smith <benselwynsmith@googlemail.com>
benmss
force-pushed
the
703-improve-commit-finder-tests
branch
from
6b7dea8 to
4ee5b81
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR improves the reliability of the optional suffix indexing aspect of the commit finder.
Description of changes
The commit finder is a complex system with many parts. It is important that we ensure each part is behaving as expected, as well as the whole system producing expected results. This PR focuses on one aspect: optional suffix indexing, which helps detect parts of a version suffix that do not necessarily need to match in the tags. To improve reliability of this aspect, this functionality is moved into a new function and tested appropriately.
Related issues
Updates #703